ACK Sharding: "Invalidate" cache after moving between shards #192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: aws-controllers-k8s/community#2545
Description of changes:
Due to the limitation (or design implementation) of k8s controller-runtime library, we have no control to hot reload / invalidate the cache of resources if a resource's labels are changed, for example.
In the sharding context of ACK controllers, by checking if that resource (from cache) still belongs to that controller, we ensure that 2 or more controllers will not overlap between each other in the context of moving a resource from one shard to another.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.