Skip to content

aft-customizations ignores the maximum_concurrent_customization parameter (Part 2) #604

Description

@wellsiau-aws

Terraform Version & Prov:

AFT Version:
1.18.0

Terraform Version & Provider Versions
n/a

Bug Description
Previously we reported the hardcoded value in aft-customizations module as reported here. This issue pointed the hardcoded value in one segment of the template, but missed to mention another location where the hardcoded value still existed here:

"Below Maximum Execution Threshold?": {
"Type": "Choice",
"Choices": [
{
"Variable": "$.running_executions.running_pipelines",
"NumericLessThan": 5,
"Next": "Execute Pipelines"
}
],
"Default": "Wait on Pipeline Executions"
},

To Reproduce
Steps to reproduce the behavior:

  1. Set maximum_concurrent_customization to value higher than 5
  2. Invoke customization with high number of target, i.e 20 accounts
  3. Notice the initial invocation will run against total maximum_concurrent_customization parallel pipelines.
  4. The next pipeline will be maxed out at 5 parallel.

Expected behavior
maximum_concurrent_customization should be honored on all part of the modules/aft-customizations/states/invoke_customizations.asl.json

Related Logs
n/a

Additional context
Relevant issue : 395

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpending investigationIssue needs further investigation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions