Skip to content

[Java] Adaptive sampling test case #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Java] Adaptive sampling test case #442

wants to merge 1 commit into from

Conversation

majanjua-amzn
Copy link
Contributor

Description

Adding a test case for an account that is using adaptive sampling.

  • RuleA in this account accepts traffic from the main service and has a sampling rate of 0% with 0/s reservoir, but has adaptive sampling configured.
  • RuleB accepts traffic from the remote service and has 0% sampling rate, 0/s reservoir, and no boost configuration
  • The main service defines a dummy anomaly condition to ensure it does not perform any boosting on its own
  • The remote service has a local configuration defining 500 response code errors as anomalies which will trigger boost in RuleA

Changes

  • Added test file for new case that uses a static version of ADOT that is saved in an S3 bucket in the account - this will be updated later
  • Terraform templates are added for the new test case, applying adaptive sampling configurations to the applications as needed on top of the regular boilerplate application deployment instructions
  • A unique traffic generation script was added to ensure we have control over the anomaly rate and sampling that occurs in this account
  • Trace validation is updated to allow for partial traces to be searched for in the account and validated
  • Expected data templates and validation configs added for the new test cases

Risks

  • Will cause a build failure in ADOT Java's "Validate E2E Tests Are Accounted For" as this test is not currently included there, I will follow up this PR with an exclusion for this test in the meantime
  • No risk of alarms, etc., as this PR is a new test with minimal change to shared logic

Testing

https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/16893409299

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@majanjua-amzn majanjua-amzn requested a review from harrryr August 11, 2025 22:57
@majanjua-amzn majanjua-amzn self-assigned this Aug 11, 2025
@majanjua-amzn majanjua-amzn added the enhancement New feature or request label Aug 11, 2025
@majanjua-amzn majanjua-amzn requested review from liustve and removed request for harrryr and liustve August 11, 2025 22:58
@majanjua-amzn majanjua-amzn marked this pull request as draft August 11, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant