Merge SDK and Lambda Releases #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
reviewed
Aug 20, 2025
.github/workflows/release-build.yml
Outdated
Comment on lines
101
to
130
| # Create release notes template | ||
| cat > release_notes.md << 'EOF' | ||
| This release contains the following upstream components: | ||
|
|
||
| - `@opentelemetry/api` - <dependency version number> | ||
| - `@opentelemetry/auto-configuration-propagators` - <dependency version number> | ||
| - `@opentelemetry/auto-instrumentations-node` - <dependency version number> | ||
| - `@opentelemetry/core` - <dependency version number> | ||
| - `@opentelemetry/exporter-metrics-otlp-grpc` - <dependency version number> | ||
| - `@opentelemetry/exporter-metrics-otlp-http` - <dependency version number> | ||
| - `@opentelemetry/exporter-trace-otlp-proto` - <dependency version number> | ||
| - `@opentelemetry/exporter-zipkin` - <dependency version number> | ||
| - `@opentelemetry/id-generator-aws-xray` - <dependency version number> | ||
| - `@opentelemetry/instrumentation` - <dependency version number> | ||
| - `@opentelemetry/instrumentation-aws-sdk` - <dependency version number> | ||
| - `@opentelemetry/propagator-aws-xray` - <dependency version number> | ||
| - `@opentelemetry/resource-detector-aws` - <dependency version number> | ||
| - `@opentelemetry/resources` - <dependency version number> | ||
| - `@opentelemetry/sdk-metrics` - <dependency version number> | ||
| - `@opentelemetry/sdk-node` - <dependency version number> | ||
| - `@opentelemetry/sdk-trace-base` - <dependency version number> | ||
| - `@opentelemetry/semantic-conventions` - <dependency version number> | ||
| - `<ANY NEW DEPENDENCIES>` - <new dependency version number> | ||
|
|
||
| This release also publishes to public ECR and NPM. | ||
| * See ADOT node auto-instrumentation Docker image v${{ github.event.inputs.version }} in our public ECR repository: | ||
| https://gallery.ecr.aws/aws-observability/adot-autoinstrumentation-node | ||
| * See version ${{ github.event.inputs.version }} in our NPM repository: | ||
| https://www.npmjs.com/package/@aws/aws-distro-opentelemetry-node-autoinstrumentation | ||
| EOF |
There was a problem hiding this comment.
Can we auto-generate this? Is it really necessary to have an engineer add all this?
There was a problem hiding this comment.
updated to automate.
wangzlei
previously approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
We plan to consolidate our ADOT SDK and Lambda layer releases for future versions. This PR merges the Lambda release workflow into the main release workflow, and publishes the layer artifacts and ARN notes to the same Github release as the SDK.
The release build workflow also now includes the SDK release notes with our upstream dependency versions to eliminate the manual effort needed when updating release notes.
Tested a modified version of this workflow in my personal work which updated an existing draft release without publishing any artifacts. The resulting release looks like this: https://github.com/ezhang6811/aws-otel-js-instrumentation/releases/tag/v2.0.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.