Update v2_app.yaml #469
Open
Update v2_app.yaml #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #, if available: Envoy proxy Pod not starting Description of changes: Missing Reference to service account causing Envoy Proxy to get Non-Authorized Error from IAM: Unauthorized to perform appmesh:StreamAggregatedResources
|
This seems to be related to https://www.eksworkshop.com/intermediate/330_app_mesh/port_to_app_mesh/trigger_sidecar_injection/. I will approve this change, but we should probably have a dedicated workshop code repository where this code should reside. Examples in this repository should be self-contained and should not require user to follow adhoc steps as enumerated in the workshop documentation as they get stale. I will create an issue to move examples/apps out of this repository. |
kiranmeduri
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Envoy proxy Pod not starting
Description of changes:
Missing Reference to service account causing Envoy Proxy to get Non-Authorized Error from IAM: Unauthorized to perform appmesh:StreamAggregatedResources
An update its required on the V1 deployment files as well.
Updated reference should also be updated on the Docs of EKS Workshop: aws-samples/eks-workshop#1298
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.