Skip to content

Updated example in java to use partitions#2160

Open
mahnushm wants to merge 25 commits intoajewell/bucketsfrom
mahnushm-partition-example-java
Open

Updated example in java to use partitions#2160
mahnushm wants to merge 25 commits intoajewell/bucketsfrom
mahnushm-partition-example-java

Conversation

@mahnushm
Copy link
Copy Markdown

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mahnushm mahnushm requested a review from a team as a code owner March 24, 2026 22:48
@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Adding GetNumberOfQueries and defaultNumberOfPartitions.
@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

.build();


// The number can be obtained using transformClient.getNumberOfQueries(query)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to be specific on what number can be obtained. Number of queries?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will add transformClient.getNumberOfQueries(query) to show its use case too.

@github-actions
Copy link
Copy Markdown

@mahnushm and @rishav-karanjit, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Testing a value that is not power of 2
@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Updated maximumNumberOfPartitions to 4 and clarified defaultNumberOfPartitions constraints.
@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

}
else {
// Adding the result for this partition
allResults.addAll(queryResponse.items());
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if response is paginated and has more results?

@github-actions
Copy link
Copy Markdown

@mahnushm and @sharmabikram, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Updated number of partitions for beacons and adjusted related logic to ensure correct handling of query results.
@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Removed unused imports related to QueryInputTransform.
@github-actions
Copy link
Copy Markdown

Detected changes to the release files or to the check-files action

@github-actions
Copy link
Copy Markdown

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants