fix: Add additional dependencies for immutable

[acioc]

Description of changes:
As a result of dafny-lang/dafny#559 we need to add 2 additional dependencies if we are running the latest version of Dafny locally. This will likely be reverted once we add them to dafny-lang/dafny.msbuild#10 and update our version of dafny.msbuild to use the latest version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[lavaleri]

AWS CodeBuild CI Report

• CodeBuild project: DafnyESDK
• Commit ID: 44a7f16
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[lavaleri]

LGTM. Can you get one more person to sanity check that this update unblocks the local build instructions?

[lavaleri]

Taking another look, we shouldn't need to add System.Runtime to fix our local build. System.Collections.Immutable should be enough.

[MatthewBennington]

I'm not sure we should include fixes for versions of Dafny we aren't technically building with. I'm fine with this change (pending my one comment), but once Dafny gets onto real releases, we shouldn't do this.

[acioc]

Taking another look, we shouldn't need to add System.Runtime to fix our local build. System.Collections.Immutable should be enough.

I ran into a number of issues with Dafny when didn't have System.Runtime. Since this is just for our team though and it works without, I'll remove the extra line for now.

[acioc]

I'm not sure we should include fixes for versions of Dafny we aren't technically building with. I'm fine with this change (pending my one comment), but once Dafny gets onto real releases, we shouldn't do this.

I agree! I also think we'll want to change our Dafny instructions so you don't need to pull down Dafny and build it in order to get everything working.

[lavaleri]

AWS CodeBuild CI Report

• CodeBuild project: DafnyESDK
• Commit ID: 9be256d
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository