Set the correct runtime flags for FIPS binaries #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elad Solomon <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 95.80% 92.36% -3.44%
==========================================
Files 61 73 +12
Lines 8143 9659 +1516
Branches 0 9659 +9659
==========================================
+ Hits 7801 8922 +1121
- Misses 342 450 +108
- Partials 0 287 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
aws-lc-sys-fips-static-runtime
branch
4 times, most recently
from
2bdaa45 to
aa95634
Compare
justsmth
force-pushed
the
aws-lc-sys-fips-static-runtime
branch
3 times, most recently
from
e54115b to
47dcd3d
Compare
justsmth
force-pushed
the
aws-lc-sys-fips-static-runtime
branch
from
47dcd3d to
dc00955
Compare
|
@justsmth thanks for updating the PR! 🙏 Looks like the tests are all passing. when do you expect we move forward with this PR? |
justsmth
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #929
Description of changes:
Currently in FIPS_SHARED mode the FIPS binaries are built with different compilation flags that do not inherit the static runtime from the
crt-statictarget feature flag.This change propagates this settings explicitly into the compilation flags of FIPS using a new CMAKE option that is turned on when
crt-statictarget feature is on.Testing:
Tested by building using MSVC v14.43.3480 in debug, release and release-lto.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.