Import mldsa native NTT #2903
Draft
Import mldsa native NTT #2903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2903 +/- ##
==========================================
- Coverage 78.19% 78.09% -0.10%
==========================================
Files 685 691 +6
Lines 118074 118641 +567
Branches 16617 16677 +60
==========================================
+ Hits 92330 92658 +328
- Misses 24856 25095 +239
Partials 888 888 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This was referenced Dec 19, 2025
jakemas
added a commit
that referenced
this pull request
Jan 14, 2026
…2919) ### Delocate AES, GCM, and cipher wrapper functions On AArch64, the delocator can patch up the computation of function pointers only if the pointers can be computed with a PC-relative offset in the range (-1MB, 1MB). For the function pointer computations in `crypto/fipsmodule/aes/mode_wrappers.c`, `crypto/fipsmodule/cipher/e_aes.c`, and `crypto/fipsmodule/modes/gcm.c`, this bounds condition is about to be violated by further code additions to AWS-LC, as witnessed in AES-unrelated PRs. This commit preventatively fixes the issue by adding function pointer trampolines to these files: These are stub functions immediately branching into the desired assembly routines, but close enough to the C code computing their address to ensure that their addresses will be computable using a PC-relative offset. This fix is similar to previous delocator fixes addressing the same AArch64 PC-relative offset limitation, see #2165, #2294 for examples. ### AWS-LC-Verification As there are SAW proofs for AES GCM, these changes affect the proofs ([formal-verification / fv-saw-x86_64-aes-gcm (pull_request)](https://github.com/aws/aws-lc/actions/runs/20380843167/job/58570729683?pr=2919)) and require changes in aws-lc-verification to continue proof support -- this has been added in awslabs/aws-lc-verification#180. ### Testing: Stability of the fix was tested in #2903 which added ~10,000 lines of additional AVX2 backend. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing delocator, this is #2902 but with x86 NTT and iNTT hooked up (+5000 lines of x86 asmb).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.