-
Notifications
You must be signed in to change notification settings - Fork 162
Clean up CLI code #2927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Clean up CLI code #2927
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2927 +/- ##
==========================================
- Coverage 78.22% 78.17% -0.06%
==========================================
Files 690 690
Lines 118745 119127 +382
Branches 16680 16684 +4
==========================================
+ Hits 92884 93122 +238
- Misses 24972 25124 +152
+ Partials 889 881 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samuel40791765
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Could you take the changes to pass_util.cc in this PR I closed and add the changes here as well? Seems like the changes are very related to what we're trying to achieve here, thanks!
|
Valgrind reports use of uninitialized data: |
|
The PR has several conflicts, largely due to formatting changes. |
Description of changes:
This PR addresses the remaining comments from PRs #2877 and #2898. I also took the liberty to clean up
tool-opensslto make our code easier to read.Testing:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.