Skip to content

Conversation

@nhatnghiho
Copy link
Contributor

Description of changes:

This PR addresses the remaining comments from PRs #2877 and #2898. I also took the liberty to clean up tool-openssl to make our code easier to read.

Testing:

Unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nhatnghiho nhatnghiho requested a review from a team as a code owner January 2, 2026 18:23
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 33.60656% with 810 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.17%. Comparing base (8238483) to head (80e4bf3).

Files with missing lines Patch % Lines
tool-openssl/rsa_test.cc 11.56% 451 Missing ⚠️
tool-openssl/pkey_test.cc 26.41% 78 Missing ⚠️
tool-openssl/crl_test.cc 33.33% 59 Missing and 1 partial ⚠️
tool-openssl/req_test.cc 17.64% 56 Missing ⚠️
tool-openssl/dhparam_test.cc 28.94% 54 Missing ⚠️
tool-openssl/x509_test.cc 60.82% 38 Missing ⚠️
tool-openssl/ec_test.cc 51.06% 23 Missing ⚠️
tool-openssl/dgst.cc 26.92% 19 Missing ⚠️
tool-openssl/genrsa_test.cc 34.61% 17 Missing ⚠️
tool-openssl/enc.cc 81.81% 4 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
- Coverage   78.22%   78.17%   -0.06%     
==========================================
  Files         690      690              
  Lines      118745   119127     +382     
  Branches    16680    16684       +4     
==========================================
+ Hits        92884    93122     +238     
- Misses      24972    25124     +152     
+ Partials      889      881       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@samuel40791765 samuel40791765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Could you take the changes to pass_util.cc in this PR I closed and add the changes here as well? Seems like the changes are very related to what we're trying to achieve here, thanks!

@justsmth
Copy link
Contributor

justsmth commented Jan 5, 2026

Valgrind reports use of uninitialized data:

Syscall param fstatat(file_name) points to uninitialised byte(s)
   at 0x4CCA71E: fstatat (in /usr/lib64/libc.so.6)
   by 0x41C66B: RemoveFile(char const*) (in ...)
   by 0x44D7E1: (anonymous namespace)::DhparamComparisonTest::TearDown() (in ...)

samuel40791765
samuel40791765 previously approved these changes Jan 5, 2026
@justsmth
Copy link
Contributor

justsmth commented Jan 9, 2026

The PR has several conflicts, largely due to formatting changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants