Skip to content

Conversation

@nhatnghiho
Copy link
Contributor

@nhatnghiho nhatnghiho commented Jan 7, 2026

Issues:

Resolves P361175454

Description of changes:

Fix failing Windows Docker image build

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@nhatnghiho nhatnghiho force-pushed the windows-image-fix branch 3 times, most recently from 4d24ed1 to 337e66a Compare January 7, 2026 02:22
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.22%. Comparing base (8238483) to head (91b81cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2931   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files         690      690           
  Lines      118745   118745           
  Branches    16680    16680           
=======================================
+ Hits        92884    92885    +1     
+ Misses      24972    24971    -1     
  Partials      889      889           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nhatnghiho nhatnghiho marked this pull request as ready for review January 13, 2026 19:06
@nhatnghiho nhatnghiho requested a review from a team as a code owner January 13, 2026 19:06
@nhatnghiho nhatnghiho changed the title Fix failing Window Docker image build Fix failing Windows Docker image build Jan 13, 2026
Copy link
Member

@skmcgrail skmcgrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for tracking this down

@skmcgrail skmcgrail requested a review from justsmth January 13, 2026 19:40
@nhatnghiho nhatnghiho enabled auto-merge (squash) January 13, 2026 21:04
@nhatnghiho nhatnghiho merged commit d91d05d into aws:main Jan 13, 2026
399 of 402 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants