Add support for Big Endian in ACVP tool #2938
Merged
+29
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2938 +/- ##
=======================================
Coverage 78.22% 78.22%
=======================================
Files 690 690
Lines 118745 118745
Branches 16680 16678 -2
=======================================
+ Hits 92889 92890 +1
+ Misses 24967 24965 -2
- Partials 889 890 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samuel40791765
force-pushed
the
big-endian-go
branch
from
f24b993 to
a17f92b
Compare
justsmth
approved these changes
Jan 14, 2026
skmcgrail
approved these changes
Jan 14, 2026
samuel40791765
added a commit
to samuel40791765/aws-lc
that referenced
this pull request
Jan 15, 2026
This was change needed to move forward with ACVP testing on powerpc64
for NetOS.
Our ACVP tool was not working properly on the PowerPC Big Endian
platform that NetOS needs to support. go1.21 has support for
`binary.NativeEndian`, but we can't use the newer version yet. This uses
a workaround with `unsafe.Pointer` until we can upgrade.
This is harder to test, but it might be doable by recompiling the cross
compilation tool chain we have with gccgo enabled. It's harder to
branch out the logic within the script to account for the different
behavior though, might do so in a follow up PR.
Works on the powerpc host NetOS lent us. Built with `gccgo` from gcc-12
with a powerpc64 cross compilation toolchain:
```
CC=powerpc64-unknown-linux-gnu-gcc \
GCCGO=powerpc64-unknown-linux-gnu-gccgo \
CGO_ENABLED=1 \
GOOS=linux \
GOARCH=ppc64 \
go build -compiler gccgo \
-gccgoflags '-static -mcpu=e6500' \
-o acvptool
```
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
(cherry picked from commit d82aea4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
This was change needed to move forward with ACVP testing on powerpc64 for NetOS.
Description of changes:
Our ACVP tool was not working properly on the PowerPC Big Endian platform that NetOS needs to support. go1.21 has support for
binary.NativeEndian, but we can't use the newer version yet. This uses a workaround withunsafe.Pointeruntil we can upgrade.Call-outs:
This is harder to test, but it might be doable by recompiling the cross compilation tool chain we have here with gccgo enabled. It's harder to branch out the logic within the script to account for the different behavior though, might do so in a follow up PR.
Testing:
Works on the powerpc host NetOS lent us. Built with
gccgofrom gcc-12 with a powerpc64 cross compilation toolchain:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.