Set maxConcurrentStreams on HTTP/2 stream manager so that the MAX_CON…#6812
Merged
zoewangg merged 2 commits intofeature/master/crtH2from Mar 24, 2026
Merged
Set maxConcurrentStreams on HTTP/2 stream manager so that the MAX_CON…#6812zoewangg merged 2 commits intofeature/master/crtH2from
zoewangg merged 2 commits intofeature/master/crtH2from
Conversation
…NECTIONS setting is respected for HTTP/2. Also improved the error message when HTTP/2 is configured with the sync client to clarify available options.
TingDaoK
approved these changes
Mar 24, 2026
...ients/aws-crt-client/src/main/java/software/amazon/awssdk/http/crt/AwsCrtHttpClientBase.java
Outdated
Show resolved
Hide resolved
|
S-Saranya1
approved these changes
Mar 24, 2026
…dk/http/crt/AwsCrtHttpClientBase.java Co-authored-by: Dengke Tang <815825145@qq.com>
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation and Context
Follow-up improvements to the CRT HTTP/2 support:
CRT.awsIsTransientError()instead of deprecatedHttpClientConnection.isErrorRetryable()maxConcurrentStreamsonHttp2StreamManagerOptionsso the MAX_CONNECTIONS setting is respected for HTTP/aws-crt-javato 0.43.9Modifications
async HTTP client
maxConnectionsPerEndpointtomaxStreamsPerEndpointfor clarity. SetmaxConcurrentStreamsonHttp2StreamManagerOptionsso MAX_CONNECTIONS is honored for HTTP/2HttpClientConnection.isErrorRetryable()withCRT.awsIsTransientError(). Removedresolved TODO comments
serverSendsRstStreamtest — RST_STREAM is not retryable, so the exception should beHttpException, notIOExceptionaws-crt-javafrom 0.43.5 to 0.43.9Testing
Updated existing H2ErrorTest assertion
Existing unit and integration tests pass
Added unit tests
Ran existing tests
Manual testing performed
Types of changes
Checklist
mvn clean install -pl :aws-crt-clientsucceeds for affected modulesLaunchChangelog
License