Support bearer tokens through environment for Bedrock #3266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md. |
alextwoods
approved these changes
Jul 2, 2025
Contributor
alextwoods
left a comment
alextwoods
left a comment
There was a problem hiding this comment.
Looks good overall - minor comments.
gems/aws-sdk-bedrock/lib/aws-sdk-bedrock/plugins/bearer_authorization.rb
Outdated
Show resolved
Hide resolved
|
Detected 3 possible performance regressions:
|
mullermp
commented
Jul 2, 2025
richardwang1124
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports bearer tokens through ENV only for Bedrock. Scoped to two clients for now (others are planned). Precedence of the bearer token will also enforce this auth scheme preference (not yet implemented). A metric is added when used.
Alternate approach is to put logic in TokenProviderChain to read from ENV (perhaps a future generalized approach can do this).