Skip to content

Fix incorrect typescript types #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix incorrect typescript types #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/full_sdk/lib/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as express from 'aws-xray-sdk-express';
import { captureMySQL } from 'aws-xray-sdk-mysql';
import { capturePostgres } from 'aws-xray-sdk-postgres';
import captureMySQL from 'aws-xray-sdk-mysql';
import capturePostgres from 'aws-xray-sdk-postgres';

export * from 'aws-xray-sdk-core';

Expand Down
4 changes: 2 additions & 2 deletions packages/full_sdk/test-d/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as express from 'aws-xray-sdk-express';
import { captureMySQL } from 'aws-xray-sdk-mysql';
import { capturePostgres } from 'aws-xray-sdk-postgres';
import captureMySQL from 'aws-xray-sdk-mysql';
import capturePostgres from 'aws-xray-sdk-postgres';
import { expectType } from 'tsd';
import * as AWSXRay from '../lib';

Expand Down
3 changes: 2 additions & 1 deletion packages/mysql/lib/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export * from './mysql_p';
import captureMySQL from './mysql_p';
export = captureMySQL;
3 changes: 2 additions & 1 deletion packages/mysql/lib/mysql_p.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import * as AWSXRay from 'aws-xray-sdk-core';
import * as MySQL from 'mysql';

export function captureMySQL(mysql: typeof MySQL): captureMySQL.PatchedMySQL;
declare function captureMySQL(mysql: typeof MySQL): captureMySQL.PatchedMySQL;
export = captureMySQL;

declare namespace captureMySQL {
interface PatchedQueryFunction {
Expand Down
2 changes: 1 addition & 1 deletion packages/mysql/test-d/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import * as AWSXRay from 'aws-xray-sdk-core';
import * as MySQL from 'mysql';
import { expectType } from 'tsd';
import { captureMySQL } from '../lib';
import captureMySQL from '../lib';

const segment = AWSXRay.getSegment();

Expand Down
3 changes: 2 additions & 1 deletion packages/postgres/lib/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export * from './postgres_p';
import capturePostgres from './postgres_p';
export = capturePostgres
3 changes: 2 additions & 1 deletion packages/postgres/lib/postgres_p.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import * as AWSXRay from 'aws-xray-sdk-core';
import * as PG from 'pg';

export function capturePostgres(pg: typeof PG): capturePostgres.PatchedPostgres;
declare function capturePostgres(pg: typeof PG): capturePostgres.PatchedPostgres
export = capturePostgres;

declare namespace capturePostgres {
interface CaptureQueryMethod {
Expand Down
2 changes: 1 addition & 1 deletion packages/postgres/test-d/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import * as AWSXRay from 'aws-xray-sdk-core';
import * as PG from 'pg';
import { expectType } from 'tsd';
import { capturePostgres } from '../lib';
import capturePostgres from '../lib';

const segment = AWSXRay.getSegment();

Expand Down
Loading