refactor(s2n-events): Reduce generated diffs when changing metric definitions#2993
Open
Mark-Simulacrum wants to merge 1 commit intoaws:mainfrom
Open
refactor(s2n-events): Reduce generated diffs when changing metric definitions#2993Mark-Simulacrum wants to merge 1 commit intoaws:mainfrom
Mark-Simulacrum wants to merge 1 commit intoaws:mainfrom
Conversation
Mark-Simulacrum
force-pushed
the
reduce-metrics-diffs
branch
from
7ead379 to
bdf831d
Compare
Mark-Simulacrum
force-pushed
the
reduce-metrics-diffs
branch
from
bdf831d to
a4a9950
Compare
Previously the raw integers were embedded in multiple places, and inserting into the middle of the list caused all integers to change. This meant a huge diff for a tiny change, and also increased the risk of merge conflicts. This updates the generator to have a list of constants each with value (previous + 1), which means that any change should only touch ~1 adjacent constant to any newly added metric at most. This shouldn't have any change in runtime behavior or performance since all offsets/indices remain computed at compile-time.
Mark-Simulacrum
force-pushed
the
reduce-metrics-diffs
branch
from
a4a9950 to
843f433
Compare
camshaft
approved these changes
Mar 4, 2026
Collaborator
Author
|
I'll rebase this once the generator is approved since it needs rebasing after any event-touching PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
Previously the raw integers were embedded in multiple places, and inserting into the middle of the list caused all integers to change. This meant a huge diff for a tiny change, and also increased the risk of merge conflicts. This updates the generator to have a list of constants each with value (previous + 1), which means that any change should only touch ~1 adjacent constant to any newly added metric at most.
This shouldn't have any change in runtime behavior or performance since all offsets/indices remain computed at compile-time.
Call-outs:
n/a
Testing:
There's some unit/integration tests and I've poked through a couple of example events and things look reasonable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.