fix: include version file in the distribution#249
Conversation
|
Hi thanks for opening this! This is interesting error the VERSION file is included in the MANIFEST.in is it not working somehow? |
|
Also, apologies for late review seems the build checks expired, if you could push an empty commit or allow edits by Maintainers would be great! |
9e3e117 to
b517d94
Compare
The __version__ can now be accessed at runtime. Tested with the following. We can see the version being copied by build. It also shows up in the sdist. ```bash python -m pip install build python -m build tar -xzf ./dist/sagemaker_core-1.0.24.tar.gz ls -l sagemaker_core-1.0.24 total 31 -rw-r--r-- 1 RM13 1049089 11558 Feb 12 16:54 LICENSE -rw-r--r-- 1 RM13 1049089 15 Feb 12 16:54 MANIFEST.in -rw-r--r-- 1 RM13 1049089 4945 Feb 24 13:57 PKG-INFO -rw-r--r-- 1 RM13 1049089 1441 Feb 24 13:54 pyproject.toml -rw-r--r-- 1 RM13 1049089 3647 Feb 12 16:54 README.rst -rw-r--r-- 1 RM13 1049089 133 Feb 24 13:57 setup.cfg drwxr-xr-x 1 RM13 1049089 0 Feb 24 13:57 src/ -rw-r--r-- 1 RM13 1049089 6 Feb 24 13:53 VERSION ``` Closes aws#248
b517d94 to
4ddaaad
Compare
|
Just rebased it, hopefully that will reset them.
It's not included in the sdist. I didn't notice the manifest.in file in the repo. Could be related to the https://setuptools.pypa.io/en/latest/userguide/datafiles.html#include-package-data |
The version can now be accessed at runtime.
Tested with the following. We can see the version being copied by build. It also shows up in the sdist.
Closes #248
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.