fix(packaging): move rllm git dependency to tool.uv.sources#77
Merged
Conversation
PyPI rejects direct-reference (git URL) dependencies in uploaded packages, which caused the v0.1.3 publish workflow to fail with a 400: "Can't have direct dependency: rllm @ git+...". Declare the rllm git source in [tool.uv.sources] instead of inline in the [rllm] extra, and switch the verl extra's rllm-model-gateway pin from a git+subdirectory URL to the PyPI spec (>=0.1.0). The published wheel metadata is now free of git URLs while 'uv pip install -e .[rllm]' still resolves rllm from GitHub for source installs.
lyzustc
reviewed
Jun 30, 2026
| "flash-attn==2.8.3", | ||
| "qwen-vl-utils", | ||
| "rllm-model-gateway @ git+https://github.com/rllm-org/rllm.git#subdirectory=rllm-model-gateway", | ||
| "rllm-model-gateway>=0.1.0", |
Contributor
There was a problem hiding this comment.
It is a long time ago since we release the latest pypi rllm-model-gateway https://pypi.org/project/rllm-model-gateway/. I think we can make a new pypi release after merging rllm-org/rllm#715 so the latest rllm-model-gateway could be installed.
lyzustc
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.1.3 PyPI publish workflow failed at the
uv publishstep:PyPI rejects direct-reference (git URL) dependencies in uploaded packages. Two extras carried git URLs:
[rllm]→rllm @ git+...(rllm is not published to PyPI)[verl]→rllm-model-gateway @ git+...#subdirectory=...(this package is on PyPI)allow-direct-references = trueonly lets hatchling build the wheel locally; it has no effect on PyPI's upload validation.Fix
rllmgit source in[tool.uv.sources]instead of inline in the[rllm]extra. The published wheel metadata becomes a plainRequires-Dist: rllm; extra == 'rllm', whileuv pip install -e ".[rllm]"still resolves rllm from GitHub for source installs.verlextra'srllm-model-gatewaypin from the git+subdirectory URL to the PyPI spec>=0.1.0(already used by theslimeextra).Verification
Built the wheel locally and inspected
METADATA— nogit+/ direct-referenceRequires-Distlines remain:Notes
uv.lockis intentionally not regenerated here —main's lock is already stale anduv lockpulls in a large unrelated dependency cascade; that belongs in a separate PR.v0.1.3release/tag (pointing at the pre-fix commit) must be deleted and recreated againstmainso a fresh, clean artifact is built and published.