This repository was archived by the owner on Jul 1, 2024. It is now read-only.
#11 - add multiple form field names for use with different ADFS versions #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groboclown
changed the title
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 98.1% 98.11% +0.01%
==========================================
Files 5 5
Lines 317 319 +2
Branches 42 42
==========================================
+ Hits 311 313 +2
Misses 3 3
Partials 3 3
Continue to review full report at Codecov.
|
|
@JordonPhillips I'm pinging you because you are to be the top contributor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#11
Description of changes:
Keeps the original ADFS form names, and adds in the alternate
UserNameandPasswordfields for compatibility with other login forms. Note that this implementation allows for combinations that aren't expected (old + new form names).Includes a new unit test for checking the alternate names.
This also includes some minor styling updates to allow
make prcheckpass.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.