Open
Conversation
lostella
reviewed
Dec 1, 2023
| def load_datasets( | ||
| metadata: Path, | ||
| train: Path, | ||
| validation: Optional[Path], |
Contributor
There was a problem hiding this comment.
This is breaking the tests I think
Contributor
|
Hey @melopeo, could you maybe update the OP to explain the motivation behind this? For example, why would one want to fix the validation data, when that could be considered a degree of freedom (some ways of setting it up may be better than others in some use cases; how to do that best may even depend on whether you use it for say model tuning vs early stopping) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
TrainDatasets currently have only fields for train and test datasets. In this commit we add the optional case for validation dataset.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup