Add conditional save, update and delete operation support for DynamoDB entities. Fixes #gh-1147#1371
Merged
maciejwalkowiak merged 5 commits intoawspring:mainfrom Sep 14, 2025
Merged
Conversation
vyomrastogi
commented
Apr 13, 2025
| * | ||
| * @see PutItemEnhancedRequest | ||
| */ | ||
| <T> void save(PutItemEnhancedRequest<T> putItemEnhancedRequest, Class<T> clazz); |
Contributor
Author
There was a problem hiding this comment.
Dear Reviewers,
Here I opted to make this method void as DynamoDbTable.putItem does not return updated entity. There is possibility if someone is using extensions then the entity would have been update at db layer and hence passed entity would not hold latest state.
This deviates from set norm, so happy to adapt to maintain consistency. What's your recommendation ?
EnhancedRequest support for dynamoDb entities. Fixes gh-1147
EnhancedRequest support for dynamoDb entities. Fixes gh-1147*EnhancedRequest support for dynamoDb entities. Fixes #gh-1147
*EnhancedRequest support for dynamoDb entities. Fixes #gh-1147
Contributor
Author
|
Hi @MatejNedic , @tomazfernandes , @maciejwalkowiak could you please review the PR and provide feedback. This is my first PR, so I am not sure if I have missed any prerequisites, and would appreciate any feedback. Looking forward to hearing from you. |
maciejwalkowiak
approved these changes
Sep 14, 2025
Contributor
maciejwalkowiak
left a comment
There was a problem hiding this comment.
Thanks @vyomrastogi and apologies for late feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
save(PutItemEnhancedRequest)to support item put conditionallyupdate(UpdateItemEnhancedRequest)to support item update conditionallydelete(DeleteItemEnhancedRequest)to support item delete conditionally💡 Motivation and Context
At the moment DynamoDbOperation does not support conditional actions on an Entity. This would mean that developers need to get an instance of DynamoDbTable to execute lower level aws sdk methods.
The new convenience methods allow for
EnhancedRequestto be executed via DynamoDbOperation.Fixes issue #1147
💚 How did you test it?
Validated changes via Integration Tests.
📝 Checklist
🔮 Next steps