feat: add listAllObjects method to S3Template#1443
Merged
maciejwalkowiak merged 2 commits intoawspring:mainfrom Sep 14, 2025
Merged
feat: add listAllObjects method to S3Template#1443maciejwalkowiak merged 2 commits intoawspring:mainfrom
maciejwalkowiak merged 2 commits intoawspring:mainfrom
Conversation
Contributor
Author
|
I don't think my changes are related to the build failure in CI here. |
…ts-to-s3-template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This pull request adds the method
listAllObjects(bucketName)to theS3Templateclass. The methodlistObjects(bucketName, prefix)was previously added in #831.I have read the contribution guidelines below. However, this change is rather small and it didn't take a long time to implement. Its fine if you don't want the method added and close this PR. My goal was to get familiar with the setup, contributing other features for the S3Template in the future (with prior discussion).
💡 Motivation and Context
prefixto thelistObjects(...)method to retrieve all objects of the bucket. I played around with wildcards for a while, but this didn't work out. In the end, the solution is passing the empty string as prefixfindAllObjects()gives better context for the reader thanlistObjects("bucket", "")Note: I decided against adding the detail as documentation to the
listObjects(...)function, because of reason 2.💚 How did you test it?
./mvnw verifypasses📝 Checklist
🔮 Next steps
For discussion if we want to remove the
somefrom the JavaDoc here. Not sure ifsomeis related to the 1.000 objects restriction or to the prefix filter.