Fix maxMessagesPerPoll validation message in AbstractContainerOptions#1480
Merged
tomazfernandes merged 1 commit intoawspring:mainfrom Oct 4, 2025
Merged
Conversation
…ons` The message is used when validating `maxMessagesPerPoll`, but incorrectly refers to `messagesPerPoll`. Fixes awspringgh-1466
richardfearn
requested review from
MatejNedic,
maciejwalkowiak and
tomazfernandes
as code owners
Contributor
|
Thanks for the PR @richardfearn! Looking forward to more! |
tomazfernandes
pushed a commit
to tomazfernandes/spring-cloud-aws
that referenced
this pull request
Nov 1, 2025
…ons` (awspring#1480) The message is used when validating `maxMessagesPerPoll`, but incorrectly refers to `messagesPerPoll`. Fixes awspringgh-1466 (cherry picked from commit b3562aa)
tomazfernandes
pushed a commit
to tomazfernandes/spring-cloud-aws
that referenced
this pull request
Nov 1, 2025
…ons` (awspring#1480) The message is used when validating `maxMessagesPerPoll`, but incorrectly refers to `messagesPerPoll`. Fixes awspringgh-1466 (cherry picked from commit b3562aa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message is used when validating
maxMessagesPerPoll, but incorrectly refers tomessagesPerPoll.Fixes gh-1466
📢 Type of change
📜 Description
The validation message in the
AbstractContainerOptionsconstructor refers tomessagesPerPoll, but should saymaxMessagesPerPoll.💡 Motivation and Context
Validation message is incorrect and doesn't identify the parameter that needs correcting if a validation exception is thrown.
💚 How did you test it?
Tested with unit tests.
📝 Checklist
🔮 Next steps