[RFC] Non-repeating file_service_type: roundrobin1 and random1#1809
Open
koct9i wants to merge 1 commit intoaxboe:masterfrom
Open
[RFC] Non-repeating file_service_type: roundrobin1 and random1#1809koct9i wants to merge 1 commit intoaxboe:masterfrom
koct9i wants to merge 1 commit intoaxboe:masterfrom
Conversation
These servicing modes does not repeat file until completion previous operation. Streaming IO-engines might not handle several requests to one "file" at once. Or such workload might not match any real scenarios. Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
Collaborator
|
I think the general idea is fine. I will take a closer look later but here are some general comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These servicing modes does not repeat file until completion previous operation.
( i.e. when nrfiles > iodepth fio should chose files which has no in-flight I/O )
Streaming IO-engines might not handle several requests to one "file" at once.
Or such workload might not match any real scenarios.
Signed-off-by: Konstantin Khlebnikov koct9i@gmail.com
Reminders:
cconv.c and bump FIO_SERVER_VER in server.h
FIO_IOOPS_VERSION in ioengines.h.
// Ok, will do later if this change is ok