sprandom: relax power of 2 block size requirement#2082
Open
vincentkfu wants to merge 1 commit intoaxboe:masterfrom
Open
sprandom: relax power of 2 block size requirement#2082vincentkfu wants to merge 1 commit intoaxboe:masterfrom
vincentkfu wants to merge 1 commit intoaxboe:masterfrom
Conversation
There is no a priori reason why the SPRandom approach cannot work with block sizes that are not a power of 2. Lift the constraint that allows only power of 2 block sizes when sprandom is enabled. This allows sprandom to be used when devices are formatted in extended LBA (DIF) mode with 520- or 4160-byte sectors. Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no a priori reason why the SPRandom approach cannot work with block sizes that are not a power of 2. Lift the constraint that allows only power of 2 block sizes when sprandom is enabled.
This allows sprandom to be used when devices are formatted in extended LBA (DIF) mode with 520- or 4160-byte sectors.
@steven-sprouse-sndk
@tomas-winkler-sndk