Skip to content

feat: add support for secp256r1#225

Open
DCMMC wants to merge 2 commits intoaxiom-crypto:community-editionfrom
CliqueOfficial:ec-double-secp256r1
Open

feat: add support for secp256r1#225
DCMMC wants to merge 2 commits intoaxiom-crypto:community-editionfrom
CliqueOfficial:ec-double-secp256r1

Conversation

@DCMMC
Copy link
Copy Markdown

@DCMMC DCMMC commented Dec 2, 2023

Background

secp256r1 is a widely used elliptic curve. Axiom's halo2-lib provides an implementation of secp256k1. At present, ec_double and check_is_on_curve in halo2-ecc ignore the ax term in y^2 = x^3 + ax + b because secp256k1 does not need this term. To make their implementation more generalized and support more curves such as secp256r1, this PR fixes ec_double and check_is_on_curve and adds an implementation of secp256r1.

Test

cargo test --package halo2-ecc --lib -- secp256r1::tests::ecdsa::test_secp256r1_ecdsa --exact --nocapture 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants