Skip to content

Grammar and Clarity Improvements#276

Open
Noisyxl wants to merge 2 commits intoaxiom-crypto:community-editionfrom
Noisyxl:community-edition
Open

Grammar and Clarity Improvements#276
Noisyxl wants to merge 2 commits intoaxiom-crypto:community-editionfrom
Noisyxl:community-edition

Conversation

@Noisyxl
Copy link
Copy Markdown

@Noisyxl Noisyxl commented Nov 28, 2024

Changes

File: halo2-ecc/src/ecc/mod.rs

  1. Added missing article "an":
    // Old:
    // is_started[idx] holds whether there is a 1 in bits with index at least (rounded_bitlen - idx)
    // New:
    // is_started[idx] holds whether there is a 1 in bits with an index at least (rounded_bitlen - idx)

  2. Added missing article "an":
    // Old:
    // this all needs strict add_unequal since A can be non-randomly chosen by adversary
    // New:
    // this all needs strict add_unequal since A can be non-randomly chosen by an adversary

File: hashes/zkevm/src/sha256/README.md

  1. Added missing "of":
    // Old:
  • output (2): the hash digest the SHA-256 algorithm on the input bytes
    // New:
  • output (2): the hash digest of the SHA-256 algorithm on the input bytes
  1. Fixed adverb form:
    // Old:
  • We convenient store the relevant cells
    // New:
  • We conveniently store the relevant cells

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant