fix: improve lock ordering in assign_lookups_in_phase#336
Open
Lil-Duckling-22 wants to merge 1 commit intoaxiom-crypto:community-editionfrom
Open
fix: improve lock ordering in assign_lookups_in_phase#336Lil-Duckling-22 wants to merge 1 commit intoaxiom-crypto:community-editionfrom
Lil-Duckling-22 wants to merge 1 commit intoaxiom-crypto:community-editionfrom
Conversation
Lock copy_manager once before the loop instead of locking it on each iteration. This improves performance and prevents potential deadlocks by maintaining a consistent lock order (copy_manager -> cells_to_lookup) across all code paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock copy_manager once before the loop instead of locking it on each iteration.
This improves performance and prevents potential deadlocks by maintaining a consistent lock order (copy_manager -> cells_to_lookup) across all code paths.