Skip to content

Commit 90c5922

Browse files
committed
strip :types from clean-ns to hide internal key from ns-interns/ns-publics
1 parent e5de03f commit 90c5922

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

review.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ deftype/defrecord no longer creates a `(def Foo ...)` var. Type names are stored
8585
- [x] Fixed CLJS test failures (`.getName` CLJ-only, error message regex)
8686
- [x] Fixed native test failures (use `sci/eval-string` instead of `tu/eval*`)
8787
- [ ] Consider caching the hierarchy tag symbol on Type to avoid string parsing in `->tag` (hot path for multimethod dispatch via `isa?`)
88+
- [x] Fix auto-completions in babashka for the new `:types` structure (custom types no longer complete)
8889

8990
## Review Status
9091

@@ -100,6 +101,6 @@ deftype/defrecord no longer creates a `(def Foo ...)` var. Type names are stored
100101
- [x] 10. `sci/impl/multimethods.cljc` — clean
101102
- [x] 11. `sci/impl/protocols.cljc` — clean
102103
- [x] 12. `sci/impl/hierarchies.cljc` — ->tag uses string parsing
103-
- [ ] 13. Tests (defrecords_and_deftype_test)
104-
- [ ] 14. Tests (core_test)
104+
- [x] 13. Tests (defrecords_and_deftype_test) — removed unused tree-seq*, clean
105+
- [x] 14. Tests (core_test) — clean
105106
- [x] 15. `sci/pprint.cljc` — renamed .-var → .-type-meta

src/sci/impl/namespaces.cljc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -473,7 +473,7 @@
473473
(sci-ns-aliases* ctx sci-ns)))
474474

475475
(defn clean-ns [m]
476-
(dissoc m :aliases :imports :obj :refer :refers))
476+
(dissoc m :aliases :imports :obj :refer :refers :types))
477477

478478
(defn sci-ns-interns* [ctx sci-ns]
479479
(let [name (sci-ns-name* ctx sci-ns)

0 commit comments

Comments
 (0)