Skip to content

Conversation

Yvinayak07
Copy link
Contributor

@Yvinayak07 Yvinayak07 commented Jul 11, 2025

Description

  • We removed plan check from T_Var node in resolve_numeric_typmod_from_exp for typmod handling of fixed length datatypes.

Issues Resolved

Task: BABEL-5976

Signed-off-by: yashneet vinayak [email protected]

engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#598

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

yashneet vinayak added 3 commits July 11, 2025 09:58
Signed-off-by: yashneet vinayak <[email protected]>
Signed-off-by: yashneet vinayak <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Jul 11, 2025

Pull Request Test Coverage Report for Build 16262538621

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.006%) to 76.028%

Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_tds/src/backend/tds/tdscomm.c 2 76.23%
contrib/babelfishpg_tsql/src/pltsql_coerce.c 2 86.18%
Totals Coverage Status
Change from base Build 16228502007: 0.006%
Covered Lines: 49910
Relevant Lines: 65647

💛 - Coveralls

yashneet vinayak added 2 commits July 14, 2025 08:55
Yashneet Vinayak added 2 commits July 29, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants