Remove custom 'createOrAlter' field in ViewStmt and grammar #3977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16763699635Details
💛 - Coveralls |
tanscorpio7
suggested changes
Jul 26, 2025
contrib/babelfishpg_tsql/src/hooks.c
Outdated
Comment on lines
7347
to
7359
| if (stmt != NULL) | ||
| { | ||
| foreach(option, stmt->options) | ||
| { | ||
| DefElem *def = (DefElem *) lfirst(option); | ||
|
|
||
| if (strcmp(def->defname, "tsql_alter_view_op") == 0) | ||
| { | ||
| tsql_alter_view_op = true; | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we instead convert ViewStmt *stmt in function signature to a boolean is_alter_view
Also is Relation depRel being used by anyone ?
There was a problem hiding this comment.
Thanks for the observation. depRel isn't used anywhere, I might have missed to remove it. Also changed the argument to bool instead of Viewstmt
1 task
R4hul04
force-pushed
the
revert-alter-flag-5-x
branch
2 times, most recently
from
15e8664 to
5c67475
Compare
added 7 commits
August 5, 2025 23:34
use Viewstmt->options Signed-off-by: Rahul Parande <[email protected]>
function Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
boolean instead of ViewStmt Signed-off-by: Rahul Parande <[email protected]>
Signed-off-by: Rahul Parande <[email protected]>
R4hul04
force-pushed
the
revert-alter-flag-5-x
branch
from
db94c45 to
2560e0c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies how we identify T-SQL
ALTER VIEWandCREATE OR ALTER VIEWoperations. Instead of using a custom field added to the PostgreSQL ViewStmt structure, we now use the standard options list mechanism insteadThis PR includes following changes:
Engine PR - babelfish-for-postgresql/postgresql_modified_for_babelfish#607
Issues Resolved
BABEL-5939
Signed off by: Rahul Parande [email protected]
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.