Ownership Chaining: Support relation references inside views #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit implements the ownership chaining support for table/view object
references inside view. The basic idea of Ownership chaining is that when
one object references another, and both have the same owner, then permissions
are only checked when the top-level object is accessed.
The scope of the current commit is to only support scenarios when parent
object is view and child objects are table/view. "[parent] view -> [child]
function" scenarios is out-of-scope for this effort.
Implementation:
Add infrastructure changes to support ownership tracking:
apply view context marking in ApplyRetrieveRule
Add walker to traverse view definition parse trees:
This enables proper ownership chaining behavior where tables and
views owned by the view owner can be accessed through the view.
Note: While infrastructure for function ownership chaining is included,
the actual implementation of function ownership chaining is out of scope
for this commit.
Issues Resolved
BABEL-6026
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.