Skip to content

Fix: properly destroy components after test case #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: properly destroy components after test case #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
} from './utils'

const rootId = 'cypress-root'
let component: SvelteComponent | null = null;

/**
* Additional styles to inject into the document.
Expand Down Expand Up @@ -84,6 +85,7 @@ interface SvelteComponent {
[key: string]: Function[]
}
}
$destroy: Function
}

interface SvelteComponentConstructor {
Expand All @@ -104,6 +106,11 @@ export function mount(
cleanupStyles(document)

let el = document.getElementById(rootId)
if (component) {
component.$destroy();
component = null;
}

if (el) {
while (el.firstChild) {
el.removeChild(el.firstChild)
Expand Down Expand Up @@ -133,11 +140,11 @@ export function mount(
target,
})

const component = new Component(allOptions)
component = new Component(allOptions)
if (options.callbacks) {
// write message callbacks
Object.keys(options.callbacks).forEach((message) => {
component.$$.callbacks[message] = [options.callbacks![message]]
component!.$$.callbacks[message] = [options.callbacks![message]]
})
}

Expand Down