fix: smooth progress and rakuen refresh animations#78
Merged
everpcpc merged 2 commits intobangumi:mainfrom Apr 12, 2026
Merged
Conversation
Scope progress row observation to individual subjects so one model update does not invalidate the whole list. Replace custom list animation heuristics with direct SwiftUI list updates and default withAnimation calls for progress, rakuen, and shared page views.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Refreshing the progress and rakuen pages could feel hitchy because list updates were propagating too broadly. In progress, the parent list observed bulk query results, so a single subject update could invalidate the visible list. In both pages, refreshes were also driving animated list structure updates.
Approach
Move progress row observation down to a per-subject container so the parent list only manages ordering. Keep list updates on explicit
withAnimationpaths with row-level transitions, while removing the previous custom diff heuristic and letting SwiftUI handle the default animation behavior.Scope
subjectIdsValidation
make build-ci