feat(test): test on multiple web3 major versions#189
Open
BobTheBuidler wants to merge 3 commits intomasterfrom
Open
feat(test): test on multiple web3 major versions#189BobTheBuidler wants to merge 3 commits intomasterfrom
BobTheBuidler wants to merge 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
web3>=7,<8for theweb3-major=7matrix entry which is unnecessary whenpoetry/the lockfile should control installed versions.poetry.lockcurrently listsweb3 = "6.11.0", showing the lockfile already pins aweb3version and the v7 override was redundant.Install web3.pystep and avoids clobberingpoetry's installation choices.web3-majorwhile lettingpoetry/the lockfile determine the actual package installed.Description
.github/workflows/pytest.yamlto remove theelsebranch that ranpoetry run pip install "web3>=7,<8".Install web3.pystep now only installs pinned ranges forweb3-major5and6and leaves7to the lockfile/default install path.Install web3.pystep.Testing
Codex Task