feat(audit): add UserOp archiver to connect Kafka reader to S3 storage #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add KafkaUserOpAuditArchiver struct - Implements read → write → commit loop for UserOp events - Add integration test (ignored due to MinIO etag limitation)
chunter-cb
approved these changes
Dec 22, 2025
wlawt
reviewed
Dec 22, 2025
crates/audit/src/archiver.rs
Outdated
| .unwrap_or_default() | ||
| .as_millis() as i64; | ||
| let event_age_ms = now_ms.saturating_sub(event.timestamp); | ||
| self.metrics.event_age.record(event_age_ms as f64); |
Contributor
There was a problem hiding this comment.
WDYT of having the audit metrics separated by tags?
Similar to how we record metrics for RPC calls here: https://github.com/base/tips/blob/master/crates/ingress-rpc/src/metrics.rs#L5-L8 , and instead we can call it type (or a better name 😅)
Contributor
Author
There was a problem hiding this comment.
Hope you had a great Christmas William. I added a type tag ("bundle" / "userop")
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic struct over
UserOpEventReaderandUserOpEventWritertraitsRuns an infinite loop that:
End-to-End Integration Tests (
integration_tests.rs)Added 7 end-to-end tests using Docker (Kafka + MinIO) covering single events, multiple events, deduplication, all event types, and full lifecycle.