Skip to content

Add subtle selected-row highlight to Walker#5402

Open
pipetogrep wants to merge 2 commits intobasecamp:devfrom
pipetogrep:walker-selected-background
Open

Add subtle selected-row highlight to Walker#5402
pipetogrep wants to merge 2 commits intobasecamp:devfrom
pipetogrep:walker-selected-background

Conversation

@pipetogrep
Copy link
Copy Markdown
Contributor

@pipetogrep pipetogrep commented Apr 23, 2026

Summary

Adds a subtle, theme-aware background to the selected Walker result in the default Omarchy theme.

This makes the active item easier to pick out while keeping the highlight tied to the existing text color token and transparency.

image image image image

@pipetogrep pipetogrep marked this pull request as ready for review April 23, 2026 14:01
Copilot AI review requested due to automatic review settings April 23, 2026 14:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a subtle, theme-aware background highlight for the currently selected Walker result in the default Omarchy theme, improving visual focus without introducing a new color token.

Changes:

  • Add a child:selected CSS rule that sets a semi-transparent background using the existing @text color token.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread default/walker/themes/omarchy-default/style.css Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 23, 2026 14:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sockbot
Copy link
Copy Markdown

sockbot commented Apr 25, 2026

This is a great accessibility improvement. I've had problems before seeing which menu item is selected.

The contrast of the selected text is a bit low, is there a way to make it more distinct from the background without changing the aesthetic?

@pipetogrep
Copy link
Copy Markdown
Contributor Author

This is a great accessibility improvement. I've had problems before seeing which menu item is selected.

The contrast of the selected text is a bit low, is there a way to make it more distinct from the background without changing the aesthetic?

I think it's intentionally subtle, I didn't want to touch those parts of the themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants