Skip to content

[Refactor] br_me_cnpj #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
folhesgabriel merged 12 commits into from
Nov 14, 2024
Merged

[Refactor] br_me_cnpj #890

folhesgabriel merged 12 commits into from
Nov 14, 2024

Conversation

@folhesgabriel
Copy link
Collaborator

@folhesgabriel folhesgabriel commented Nov 13, 2024 •
edited
Loading

Descrição do PR:

  • Este PR faz três grandes modificações na pipeline:
  1. Adiciona type hints e docstrings nas funções em utils.py
  2. Refatora a função responsável por checar as atualizações no FTP da RF
  3. Refatora as funções Asíncronas que fazem o download dos arquivos do FTP

Teste e Validações:

  • Relate os testes e validações relacionado aos dados/script:
    • Testado localmente
    • Testado na Cloud

@folhesgabriel folhesgabriel marked this pull request as draft November 13, 2024 10:34
@mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@folhesgabriel esse pull request tem conflitos 😩

@mergify mergify bot added the conflict label Nov 13, 2024
@folhesgabriel folhesgabriel self-assigned this Nov 13, 2024
@laura-l-amaral laura-l-amaral linked an issue Nov 13, 2024 that may be closed by this pull request
[fix] br_me_cnpj #886
Closed
14 tasks
@github-actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Coverage

Tests Skipped Failures Errors Time
2 0 💤 0 ❌ 2 🔥 2.050s ⏱️

@folhesgabriel folhesgabriel marked this pull request as ready for review November 13, 2024 17:51
@folhesgabriel folhesgabriel requested a review from a team November 13, 2024 18:21
@folhesgabriel folhesgabriel merged commit f0bbb9f into main Nov 14, 2024
6 checks passed
@folhesgabriel folhesgabriel deleted the staging/refactor_cnpj branch November 14, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tricktx tricktx tricktx approved these changes

Assignees

@folhesgabriel folhesgabriel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[fix] br_me_cnpj

3 participants

@folhesgabriel @tricktx