Allowing for sleep_brightness to be set to 0#1455
Allowing for sleep_brightness to be set to 0#1455jaynis wants to merge 6 commits intobasnijholt:mainfrom
Conversation
Signed-off-by: jaynis <kranz.jannis@googlemail.com>
for more information, see https://pre-commit.ci
…r string rewrites)
|
Sorry it took me so long to get to this. I've been a bit overwhelmed by the number of AI-assisted PRs opened here recently, and I've also been spending nearly every spare hour on my biggest project so far, MindRoom. I'm very supportive of using AI for coding, but many of these PRs still need careful human review because even plausible-looking changes can introduce subtle breakage. That backlog made me postpone reviewing them for a while. I've now done a batch review with Codex / GPT-5.5 (xhigh). This comment is AI-assisted, but I've reviewed the concern before posting it. One issue before this can be merged: making Specifically, The zero-value handling in #1460 fixes the underlying pattern by checking |
…holt#1460) Signed-off-by: jaynis <kranz.jannis@googlemail.com>
Signed-off-by: jaynis <kranz.jannis@googlemail.com>
for more information, see https://pre-commit.ci
|
Hi @basnijholt and thank you for your review. I have implemented the mentioned changes and kindly ask you to take another look. |
This PR updates the
sleep_brightnessrange from 1–100 to 0–100, enabling zero as a valid value. It allows lights to remain off when they receiveturn_oncalls during sleep mode and thus can prevent specific lights (e.g. ceiling lights) from turning on. This eliminates the need of special logic when e.g. turning on lights with motion sensors during night time.