Skip to content

Conversation

@laramiel
Copy link
Contributor

@laramiel laramiel commented Nov 9, 2025

  • Return abi_flags from get_local_runtime_info and pass it into the py3_runtime
  • Rework how shared-libraries are links are constructed to better meet @rules_cc cc_library.srcs requirements

This improves runtime detection for macos when using a python3.14t framework runtime.

* Return abi_flags from get_local_runtime_info and pass it into the py3_runtime
* Rework how shared-libraries are linked.

This improves runtime detection for macos when using a python3.14t framework runtime.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @laramiel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with local Python runtime detection, especially on macOS with free-threaded Python builds. It introduces explicit handling of Python's Application Binary Interface (ABI) flags and refines the shared library linking process. By accurately identifying and passing ABI information and ensuring correct library symlinking, the changes improve the robustness and compatibility of Python runtime configurations within the build system.

Highlights

  • ABI Flags Integration: Application Binary Interface (ABI) flags are now correctly retrieved from the local Python runtime and passed into the py3_runtime definition, which is crucial for distinguishing different Python builds (e.g., free-threaded versions).
  • Shared Library Linking Rework: The mechanism for constructing shared library links has been revised to better align with @rules_cc's cc_library.srcs requirements, improving build compatibility and robustness.
  • Improved macOS Runtime Detection: These changes specifically enhance runtime detection on macOS, particularly for Python versions utilizing framework runtimes like python3.14t, ensuring more accurate configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for free-threaded Python by adding abi_flags to the local runtime information. The changes include refactoring the logic for discovering Python libraries in get_local_runtime_info.py, making it more robust and maintainable. Specifically, the shared library suffix detection is centralized, and the library search paths are expanded. The abi_flags are then propagated through the Bazel rules to correctly configure the Python toolchain. Additionally, the logic for symlinking shared libraries in local_runtime_repo.bzl has been generalized to better support different platforms, especially macOS framework builds. The changes are well-structured and effectively address the goal of improving runtime detection for newer Python versions. The code quality is high, and the refactoring improves maintainability. I have no comments on any issues to address.

@rickeylev
Copy link
Collaborator

Can you clarify what "Rework how shared-libraries are links are constructed to better meet @rules_cc cc_library.srcs requirements"

What requirement does it have that wasn't being properly met?

@rickeylev
Copy link
Collaborator

Just needs a changelog entry, but otherwise LGTM

@rickeylev rickeylev enabled auto-merge November 9, 2025 20:06
@rickeylev rickeylev added this pull request to the merge queue Nov 9, 2025
Merged via the queue into bazel-contrib:main with commit c037d83 Nov 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants