-
-
Notifications
You must be signed in to change notification settings - Fork 638
fix(local): Fix local_runtime use with free-threaded python #3399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Return abi_flags from get_local_runtime_info and pass it into the py3_runtime * Rework how shared-libraries are linked. This improves runtime detection for macos when using a python3.14t framework runtime.
Summary of ChangesHello @laramiel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with local Python runtime detection, especially on macOS with free-threaded Python builds. It introduces explicit handling of Python's Application Binary Interface (ABI) flags and refines the shared library linking process. By accurately identifying and passing ABI information and ensuring correct library symlinking, the changes improve the robustness and compatibility of Python runtime configurations within the build system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for free-threaded Python by adding abi_flags to the local runtime information. The changes include refactoring the logic for discovering Python libraries in get_local_runtime_info.py, making it more robust and maintainable. Specifically, the shared library suffix detection is centralized, and the library search paths are expanded. The abi_flags are then propagated through the Bazel rules to correctly configure the Python toolchain. Additionally, the logic for symlinking shared libraries in local_runtime_repo.bzl has been generalized to better support different platforms, especially macOS framework builds. The changes are well-structured and effectively address the goal of improving runtime detection for newer Python versions. The code quality is high, and the refactoring improves maintainability. I have no comments on any issues to address.
|
Can you clarify what "Rework how shared-libraries are links are constructed to better meet @rules_cc cc_library.srcs requirements" What requirement does it have that wasn't being properly met? |
|
Just needs a changelog entry, but otherwise LGTM |
This improves runtime detection for macos when using a python3.14t framework runtime.