Open
Conversation
rrbutani
approved these changes
Jun 12, 2024
Collaborator
rrbutani
left a comment
rrbutani
left a comment
There was a problem hiding this comment.
Looks good!
If it isn't too much trouble would you mind adding a test for this? (cc_binary with -fopenmp that fails to build if these .sos aren't made available)
Member
Author
|
Sure, I'll look to putting a test together for this. IIRC where we use this may also need the addition of a |
thomasbaekkegaard
left a comment
thomasbaekkegaard
left a comment
There was a problem hiding this comment.
FYI: lib/*omp* -files are not included in LLVM-19.* distributions.
oharboe
added a commit
to Pinata-Consulting/OpenROAD
that referenced
this pull request
Mar 4, 2026
Move -fopenmp from per-target copts to a global --cxxopt in .bazelrc so all OpenROAD code is compiled with OpenMP support without needing it in each BUILD file. External BCR deps (e.g. or-tools, eigen) get -fno-openmp via --per_file_copt to avoid omp.h not found errors, since @OpenMP headers aren't in their sandbox and toolchains_llvm doesn't yet expose them (see bazel-contrib/toolchains_llvm#339). Note: src/sta (OpenSTA submodule) still has a per-target -fopenmp that should be removed in a follow-up PR to that repo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
oharboe
added a commit
to Pinata-Consulting/OpenROAD
that referenced
this pull request
Mar 4, 2026
…roject#7451 Move -fopenmp from per-target copts to a global --cxxopt in .bazelrc so all OpenROAD code is compiled with OpenMP support without needing it in each BUILD file. No performance change; this is a cleanup. External BCR deps (e.g. or-tools, eigen) get -fno-openmp via --per_file_copt to avoid omp.h not found errors, since @OpenMP headers aren't in their sandbox and toolchains_llvm doesn't yet expose them (see bazel-contrib/toolchains_llvm#339). When that is resolved, removing the exclusion will enable OpenMP for those deps too, making Eigen faster in or-tools. Note: src/sta (OpenSTA submodule) still has a per-target -fopenmp that should be removed in a follow-up PR to that repo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the OpenMP shared libraries that are needed if you compile with
-fopenmpor OpenMP target offload enabled.