Remove %workspace% before checking path#465
Open
jwbee wants to merge 1 commit intobazel-contrib:masterfrom
Open
Remove %workspace% before checking path#465jwbee wants to merge 1 commit intobazel-contrib:masterfrom
jwbee wants to merge 1 commit intobazel-contrib:masterfrom
Conversation
The paths checked by `_is_hermetic_or_exists` may begin with "%workspace%" which prevents the check for the path existing. In that case, the system module map may contain include paths that don't exist. In turn that can cause warnings for any target using layering check (notably Abseil).
fmeum
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paths checked by
_is_hermetic_or_existsmay begin with "%workspace%" which prevents the check for the path existing. In that case, the system module map may contain include paths that don't exist. In turn that can cause warnings for any target using layering check (notably Abseil).