feat(workspace-tree): Workspace tree can show external local repository #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwahbong
requested review from
coeuvre,
jfirebaugh,
cameron-martin and
vogelsgesang
as code owners
Separate and abstract the tree view specific bazel queries in prepare for adding test cases. Also pull out the configuration getter since I found it simpler to use (auto complete and check by tsc, and maybe customizing the defaults based on more complicated logic).
Besides the existing internal packages, handles handles external local repository: the packages in pattern `@repo//package/path:target`. We made the WorkspaceTreeProvider able to process only the following two patterns: * `//internal/package/path` * `@external//package/path` And normalize the patterns queried in IBazelQuerier. Simple test cases also added for package path handling.
cwahbong
force-pushed
the
workspace-tree
branch
from
91a5211 to
895bb15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the existing internal packages, handles handles external local repository: the packages in pattern
@repo//package/path:target.For building the tree structure:
WorkspaceTreeProviderable to process only the following two patterns, then normalize the patterns queried inIBazelQuerier://internal/package/path@external//package/pathUI:
BazelTargetTreeItem.getCommand(), so that clicking the targets in external local repository would jump into the source tree instead of Bazel cache path.Misc:
voidfor not waiting command/message, or properly grouping them into a promise for await.Works towards #416.