feat(codelens): Show picker for multiple targets (#476) #477
Conversation
bkolb
requested review from
cameron-martin,
coeuvre,
jfirebaugh and
vogelsgesang
as code owners
There was a problem hiding this comment.
Thanks for this contribution! I have tested it locally and it works fine. I like this new interactive approach much more then the previous "workaround" with sorting.
Nevertheless, I suggest to improve on the implementation further before merging this to master. See the following comments
bkolb
force-pushed
the
feature/multilineCodeLense
branch
from
4a0ab35 to
b55a3fb
Compare
|
Thank you for your feedback. I will work on your comments and post a new version soon. The one I just pushed has an issue that I need to fix. |
bkolb
force-pushed
the
feature/multilineCodeLense
branch
2 times, most recently
from
1b63371 to
b0a63d4
Compare
|
Can I get another round of review, please? |
There was a problem hiding this comment.
Thanks for adressing my last set of review comments. The functionality is still given and works fine locally.
Here is a next set of (opinionated) findings with the goal of improving code quality.
(Note that I am not a maintainer, so feel free to take it as a suggestion or ignore as long as none of the maintainers performs a review 😉 )
This change modifies the BazelBuildCodeLensProvider to create a target picker in case there is more than one target per category (Copy/Build/Run/Test). The motivation is to provide a better and more user-friendly experience when working with macros in BUILD files. When a macro generates multiple targets, you could run into situations where not all actions were visible anymore.
bkolb
force-pushed
the
feature/multilineCodeLense
branch
from
b0a63d4 to
77f8dbd
Compare
|
OK. I pushed again. Let me know what you think. |
|
For the record: I like the latest version a lot and would also be interested in the thoughts of @cameron-martin 😃 |
2 participants
This change modifies the BazelBuildCodeLensProvider to create a target picker in case there is more than one target per category (Copy/Build/Run/Test).
The motivation is to provide a better and more user-friendly experience when working with macros in BUILD files. When a macro generates multiple targets, you could run into situations where not all actions were visible anymore.