forked from buildfarm/buildfarm
-
Notifications
You must be signed in to change notification settings - Fork 0
upgrade bazel buildfarm to v2.7.0 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chenj-hub
wants to merge
96
commits into
bazel-ios-fork
Choose a base branch
from
jackies/upgrade-bazel-buildfarm-to-v2.7.0
base: bazel-ios-fork
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
upgrade bazel buildfarm to v2.7.0 #12
chenj-hub
wants to merge
96
commits into
bazel-ios-fork
from
jackies/upgrade-bazel-buildfarm-to-v2.7.0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker loss can signal cascading failure and shutdown for execute-only peers. Ensure that a ReportResultStage seeing an SRE does not close the stage, and that there are basic retries for remote uploads.
Works with current redis-py-cluster 2.1.3
Prevents a hang on shutdown when redis is disconnected
Use the proper name for a status code as presented when the read will not be retried.
Update platforms
* Add download metrics for buildfarm:worker * Run formatter * remove static * change IO_METRIC prometheus counter to static
* Separate channel for write api * shutdown channel on termination
* Fix deadlock by setting a timeout and removing the lock. * remove timeout as its not necessary * lint: delete unused import
Interactions with RemoteCasWriter which declare IOExceptions should throw them exclusively for failures.
JCenter is retired. Pick some mirrors from https://repo.maven.apache.org/maven2/.meta/repository-metadata.xml
Specifying --prometheus_port for either server or worker will: Override the config value if delivered as int > 0, otherwise leave the config value alone. Since prometheusPort as configured <= 0 disables the server, this permits users to specify '0' to override the config with a disable switch. Updated quick_start docs to reflect this extra parameter.
…es (buildfarm#1444) Co-authored-by: Trevor Hickey <[email protected]>
Support "rediss://" (extra 's', like https) to indicate Redis-SSL connections. For Redis client identifier, we use the `identifier` passed to RedisShardBackplane.
Specify and patch more recent rules_go and bazel_gazelle per upstream patch. Docker images work with recent HEAD releases of bazel as a result. Depends on buildfarm#1453 resolution to actually build //... Fixes buildfarm#1440
Any '.' appearance as a segment should be considered to be the current directory in the search sequence of a working_directory path.
Support a `--redis_uri` command line option for start-up.
also fixed some spelling typos.
Bumping 4.2 -> 5.3
Bump fro 0.0.6 -> 0.0.9
Don't get transitive grpc dependencies, use the ones from our `maven_install(...)`
To aid connection troubleshooting
buildfarm#1486) * Add unit test * Signal Write on complete
Closes buildfarm#1508 Cleanups: - remove the unused `ubuntu-bionic` base image - replace `ubuntu-jammy:jammy-java11-gcc` with `ubuntu-mantic:mantic-java17-gcc` - replace `amazoncorretto:19` with `ubuntu-mantic:mantic-java17-gcc` - swap inverted log file names in a file
Specifying any number of OutputPaths will ignore OutputFiles (consistent with uploads). Where an OutputPath specifies an output directory, the action must be able to create the directory itself.
Partial specification of the absolute symlink response per REAPI. Remaining work will be in output identification.
Trying to get more info on the Lombok stamping issue on Windows CI. See also bazelbuild/bazel#10363 and bazelbuild/bazel#18185
Default disabled, available with createSymlinkOutputs option in Worker config.
Problem
Enabling the findMissingBlobsViaBackplane flag in BuildfarmServer eliminates the need for the BuildfarmWorker's fmb API call. This BuildfarmWorker:fmb call was also responsible for tracking CAS entry access. As result, our CAS cache eviction strategy shifted from LRU to FIFO.
When the findMissingBlobsViaBackplane flag is enabled, the buildfarm relies on the backplane as the definitive source for CAS availability. Since we don't update CAS expiry on each access, the backplane will independently expire CAS entries based on the specified cas_expire duration, even if they are actively being read.
Solution
Updated bfServer:fmb call to perform non-blocking fmb calls to workers, allowing these workers to record access for the relevant CAS entries.
Extended expiry duration for available CAS entries in the backplane on each fmb call.
With these changes, we can utilize Bazel's experimental_remote_cache_lease_extension and experimental_remote_cache_ttl flags for incremental builds.
Closes buildfarm#1428
…m#1516) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…remove-custom-spring-exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.