forked from buildfarm/buildfarm
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade bazel-ios-fork to v2.9.0 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
chenj-hub
wants to merge
193
commits into
bazel-ios-fork
Choose a base branch
from
jackies/upgrade-bazel-buildfarm-to-v2.9.0
base: bazel-ios-fork
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upgrade bazel-ios-fork to v2.9.0 #8
chenj-hub
wants to merge
193
commits into
bazel-ios-fork
from
jackies/upgrade-bazel-buildfarm-to-v2.9.0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker loss can signal cascading failure and shutdown for execute-only peers. Ensure that a ReportResultStage seeing an SRE does not close the stage, and that there are basic retries for remote uploads.
Works with current redis-py-cluster 2.1.3
Prevents a hang on shutdown when redis is disconnected
Use the proper name for a status code as presented when the read will not be retried.
Update platforms
* Add download metrics for buildfarm:worker * Run formatter * remove static * change IO_METRIC prometheus counter to static
* Separate channel for write api * shutdown channel on termination
* Fix deadlock by setting a timeout and removing the lock. * remove timeout as its not necessary * lint: delete unused import
Interactions with RemoteCasWriter which declare IOExceptions should throw them exclusively for failures.
JCenter is retired. Pick some mirrors from https://repo.maven.apache.org/maven2/.meta/repository-metadata.xml
Specifying --prometheus_port for either server or worker will: Override the config value if delivered as int > 0, otherwise leave the config value alone. Since prometheusPort as configured <= 0 disables the server, this permits users to specify '0' to override the config with a disable switch. Updated quick_start docs to reflect this extra parameter.
…es (buildfarm#1444) Co-authored-by: Trevor Hickey <[email protected]>
Support "rediss://" (extra 's', like https) to indicate Redis-SSL connections. For Redis client identifier, we use the `identifier` passed to RedisShardBackplane.
Specify and patch more recent rules_go and bazel_gazelle per upstream patch. Docker images work with recent HEAD releases of bazel as a result. Depends on buildfarm#1453 resolution to actually build //... Fixes buildfarm#1440
Any '.' appearance as a segment should be considered to be the current directory in the search sequence of a working_directory path.
* Guard against writeObserver null race * Avoid cancellation log for StubWriteOutputStream Cancels will happen for all server->worker uploads on context cancels initiated by clients, and are normal behaviors. * Guarantee null write response for onCompleted Avoid a complaint by gRPC that a client-streaming request was completed without a response * Reset remote CAS write on initial Prevents the StubWriteOutputStream from issuing an unnecessary initial queryWriteStatus.
These instances of `format(...)` do not have placeholders and there's nothing to format.
* chore: Update proto file styling * fix path * move protp styling to file * add new line at eof
…dfarm#1549) * fix: Periodically Refresh Active Storage Workers With startTime
…" (buildfarm#1603) This reverts commit 413021d.
Node name strings provided via `cluster slots` will be byte arrays that require decoding. Use the inbuilt SafeEncoder from jedis which is used to decode all other strings.
* build: start adopting bzlmod Only four bazel dependencies were found in the existing bzlmod registry (https://registry.bazel.build/) * build: swap io_bazel_rules_go for bzlmod * build: swap gazelle for bzlmod * tests: support bzlmod I don't know why. But it works. * build: leave breadcrumbs for bzlmod migration * build(chore): MODULE.bazel.lock * build: swap buildtools for buildifier_prebuilt There are conflicts with go tooling between buildtools and protobuf.
The awk was pulling out the denominator of the metric, not the percent. Adjust the field. Before: ``` current line coverage: 1625% current function coverage: 340% ``` after: ``` current line coverage: 42% current function coverage: 51% ```
… entire repo with tags: `helm/X.Y.Z-b1` (buildfarm#1602) * add helm chart linting stage, bundle chart on helm/* tags * fix triggers * try try again * always lint before bundling * extract the helm chart version from the git tag ref * fix name * tickle the beast * too much stack overflow * better names * that's output * gussy up readme * simplify * stage 0.2.2 * put extraVolumeMounts under .Values.shardWorker * omit defaults * leave out emacs gitignore * wrong example
…ildfarm#1606) * Publish storage worker and execute worker pool size in prometheus * run formatter * add doc --------- Co-authored-by: Yuriy Belenitsky <[email protected]>
Avoid stripping the existingHash, used to calculate the slot with suffix modifiers for queue balancing. Client presentation may also move to presenting each balanced queue name, removing the coordinated calculation on the client. The name could only have been used by a client prior for name presentation or determination of queue names in redis from slot arrangement.
* set expire and drop invocationId * fix format * patch configuration doc * fix typo * re-run ci use luxe's patch * set expire when every active operation insert * fix return code * fix ci if statement --------- Co-authored-by: wangpengfei.pfwang <[email protected]> Co-authored-by: George Gensure <[email protected]>
* feat: add OSSF Scorecards workflow Adding OSSF Scorecards workflow as github action. It runs periodially. Output goes into Code Scanning alerts of GitHub. * docs(README): add some badges - OSSF Scorecard - License (from GitHub) - latest Release (from GitHub)
Remove rules_oss_audit and accompanying documentation
* fix template bugs with with * stage chart v0.2.3
* rework for bitnami redis helm chart * still doesn't work tho less specified * disable redis pwd -- not for production use * chart/bitnami-redis:18.14.2 * and later * stage chart v0.3.0
…upgrade-bazel-buildfarm-to-v2.9.0
1141041
to
3977b90
Compare
Resolved git conflict between v.2.9.0 and current bazel-ios-fork from running: git show d6c1859 --remerge-diff:
|
e438475
to
9938118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.