Skip to content

Publish rules_shtk-1.7.1 #6073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

Publish rules_shtk-1.7.1 #6073

merged 1 commit into from
Oct 2, 2025

Conversation

jmmv
Copy link
Contributor

@jmmv jmmv commented Oct 2, 2025

No description provided.

@bazel-io
Copy link
Member

bazel-io commented Oct 2, 2025

Hello @bazelbuild/bcr-maintainers, modules (rules_shtk) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 1.7.1 of the rules_shtk module. The changes are well-structured and mostly adhere to the Bazel Central Registry policies. However, I've found a critical issue in presubmit.yml where the required Bazel version for the tasks is not specified. This will cause the presubmit checks to fail. I have provided suggestions to resolve this.

@jmmv jmmv force-pushed the rules_shtk-1.7.1 branch from 4982d0f to e9c5f94 Compare October 2, 2025 01:33
@bazel-io
Copy link
Member

bazel-io commented Oct 2, 2025

Hello @protobuf-team-bot, @zhangskz, @mkruskal-google, @googleberg, modules you maintain (protobuf) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@jmmv jmmv force-pushed the rules_shtk-1.7.1 branch from e9c5f94 to 0533a29 Compare October 2, 2025 01:35
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Oct 2, 2025
meteorcloudy
meteorcloudy reviewed Oct 2, 2025
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the unrelated file under protobuf

@jmmv jmmv force-pushed the rules_shtk-1.7.1 branch from 0533a29 to 10b9140 Compare October 2, 2025 13:28
@jmmv
Copy link
Contributor Author

jmmv commented Oct 2, 2025

Oops, done. jj-vcs' eagerness to add files bit me again...

bazel-io
bazel-io approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io merged commit acd4a10 into bazelbuild:main Oct 2, 2025
20 checks passed
@bazel-io bazel-io added the auto-merged This PR is automatically merged by the BCR reviewer bot. label Oct 2, 2025
kotlaja pushed a commit to kotlaja/bazel-central-registry that referenced this pull request Oct 16, 2025
@jmmv @kotlaja
Publish rules_shtk-1.7.1 (bazelbuild#6073)
6154fd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meteorcloudy meteorcloudy meteorcloudy left review comments

@bazel-io bazel-io bazel-io approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-merged This PR is automatically merged by the BCR reviewer bot. presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmmv @bazel-io @meteorcloudy