loadingtests: add default timeout #572
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novas0x2a
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
novas0x2a
force-pushed
the
loadingtest-timeout
branch
from
285ef56 to
95fe13f
Compare
loadingtests didn't provide a way to set a timeout, which means they trip --test_verbose_timeout_warnings; this provides a basic way to do so, and sets a default timeout of short since normal loadingtests would have a hard time successfully being any larger.
novas0x2a
force-pushed
the
loadingtest-timeout
branch
from
95fe13f to
a82a131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadingtests didn't provide a way to set a timeout, which means they trip --test_verbose_timeout_warnings; this provides a basic way to do so, and sets a default timeout of short since normal loadingtests would have a hard time successfully being any larger.