Use macro name in Java strict deps fixups #17805
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name part of the target label embedded in JARs by the Java rules for the purpose of generating fixup commands for strict deps violations is now set to the macro name if the current target has been generated by a macro. Since tools such buildozer operate on the level of parsed but unevaluated BUILD files, they only see the macro name, not the name of the generated target that violated strict deps.
This change is backwards compatible in the sense that fixup command that worked before will continue to work: If the macro name is identical to the target name, nothing has changed, if it differs, the fixup command couldn't have worked before assuming the macro followed the style guide convention to only generate targets with its own name plus optionally a suffix.