Modernize CcToolchain{Features,Variables}#28789
Open
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Open
Modernize CcToolchain{Features,Variables}#28789fmeum wants to merge 1 commit intobazelbuild:masterfrom
CcToolchain{Features,Variables}#28789fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
bot
added
team-Rules-CPP
fmeum
force-pushed
the
335-artifact-chunk
branch
from
f9d7789 to
214e879
Compare
Switch from abstract classes to interfaces to enable widespread migration to records and delete a bunch of dead code.
fmeum
force-pushed
the
335-artifact-chunk
branch
from
214e879 to
4d5a250
Compare
Collaborator
Author
|
@bazel-io fork 9.1.0 |
Collaborator
Author
|
#28794 will provide the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switch from abstract classes to interfaces to enable widespread migration to records and delete a bunch of dead code.
Motivation
Work towards enabling path mapping for
cc_argsby introducing a newStringChunktype (cerisier/toolchains_llvm_bootstrapped#335)Build API Changes
No
Checklist
Release Notes
RELNOTES: None